On Wed, Feb 16, 2022 at 07:43:09PM -0800, Peter Geoghegan wrote: > > I also have a hard time making heads or tails out of the commit message of > > 44fa84881ff. It's quite long without being particularly descriptive. The > > commit just changes a lot of things at once, making it hard to precisely > > describe and very hard to review and understand. > > The commit message is high level. The important point is that we can > more or less treat all scanned_pages the same, without generally > caring about whether or not a cleanup lock could be acquired (since > the exceptions where that isn't quite true are narrow and rare). That > is the common theme, for everything.
As for myself, I particularly appreciated the clarity and detail of this commit message. (I have looked at the associated change a bit, but not deeply). Thanks, -- Justin