On Thu, Feb 24, 2022 9:33 AM Masahiko Sawada <sawada.m...@gmail.com> wrote:
>
> Thank you for the comments! I've attached the latest version patch
> that incorporated all comments I got so far. The primary change from
> the previous version is that the subscription statistics live globally
> rather than per-database.
>
Thanks for updating the patch.
Few comments:
1.
I think we should add some doc for column stats_reset in
pg_stat_subscription_activity view.
2.
+CREATE VIEW pg_stat_subscription_activity AS
SELECT
- w.subid,
+ a.subid,
s.subname,
...
+ a.apply_error_count,
+ a.sync_error_count,
+ a.stats_reset
+ FROM pg_subscription as s,
+ pg_stat_get_subscription_activity(oid) as a;
The line "a.stats_reset" uses a Tab, and we'd better use spaces here.
Regards,
Tang
