On Mon, Feb 28, 2022 12:32 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Feb 28, 2022 at 8:17 AM Masahiko Sawada <sawada.m...@gmail.com> > wrote: > > > > On Mon, Feb 28, 2022 at 11:33 AM Amit Kapila <amit.kapil...@gmail.com> > wrote: > > > > > > > > > > > (2) doc/src/sgml/monitoring.sgml > > > > > > > > + Resets statistics for a single subscription shown in the > > > > + <structname>pg_stat_subscription_stats</structname> view to > > > > zero. If > > > > + the argument is <literal>NULL</literal>, reset statistics for > > > > all > > > > + subscriptions. > > > > </para> > > > > > > > > I felt we could improve the first sentence. > > > > > > > > From: > > > > Resets statistics for a single subscription shown in the.. > > > > > > > > To(idea1): > > > > Resets statistics for a single subscription defined by the argument to > > > > zero. > > > > > > > > > > Okay, I can use this one. > > > > Are you going to remove the part "shown in the > > pg_stat_subsctiption_stats view"? I think it's better to keep it in > > order to make it clear which statistics the function resets as we have > > pg_stat_subscription and pg_stat_subscription_stats. > > > > I decided to keep this part of the docs as it is and fixed a few other > minor comments raised by you and Peter. Additionally, I have bumped > the PGSTAT_FILE_FORMAT_ID. I'll push this patch tomorrow unless there > are any other major comments. >
Thanks for your patch. I have finished the review/test for this patch. The patch LGTM. Regards, Tang
