Hi, On 2022-03-02 12:39:57 +0530, Amit Kapila wrote: > On Wed, Mar 2, 2022 at 10:39 AM Andres Freund <and...@anarazel.de> wrote: > > > > Working on rebasing shared memory stats over this. Feels *much* better so > > far. > > > > Good to hear that it helps. BTW, there is another patch [1] that > extends this view. I think that patch is still not ready but once it > is ready (which I expect to happen sometime in this CF), it might be > good if you would be able to check whether it has any major problem > with your integration.
I skimmed it briefly, and I don't see an architectural conflict. I'm not convinced it's worth adding that information, but that's a separate discussion. > > While rebasing, I was wondering why pgstat_reset_subscription_counter() has > > "all subscription counters" support. We don't have a function to reset all > > function stats or such either. > > > > We have similar thing for srlu (pg_stat_reset_slru) and slots > (pg_stat_reset_replication_slot). Neither should have been added imo. We're already at 9 different reset functions. Without a unified function to reset all stats, pretty much the only actually relevant operation. And having pg_stat_reset_shared() with variable 'reset' systems but then also pg_stat_reset_slru() and pg_stat_reset_subscription_stats() is absurd. This is just making something incomprehensible evermore incomprehensible. > For functions and tables, one can use pg_stat_reset. Not in isolation. Greetings, Andres Freund
