Hi, On 2022-03-22 11:23:16 -0400, Robert Haas wrote: > From 116bcdb6174a750b7ef7ae05ef6f39cebaf9bcf5 Mon Sep 17 00:00:00 2001 > From: Robert Haas <rh...@postgresql.org> > Date: Tue, 22 Mar 2022 11:22:26 -0400 > Subject: [PATCH v1] Add new block-by-block strategy for CREATE DATABASE.
I might have missed it because I just skimmed the patch. But I still think it should contain a comment detailing why accessing catalogs from another database is safe in this instance, and perhaps a comment or three in places that could break it (e.g. snapshot computation, horizon stuff). Greetings, Andres Freund