Michael Paquier <mich...@paquier.xyz> writes: > On Thu, Apr 07, 2022 at 11:19:15AM -0400, Robert Haas wrote: >> Here are patches for master and v14 to do things this way. Comments?
> Thanks for the patches. They look correct. For ~14, I'd rather avoid > the code duplication done by GetVirtualXIDsDelayingChkptEnd() and > HaveVirtualXIDsDelayingChkpt() that could be avoided with an extra > bool argument to the existing routine. Isn't adding another argument an API break? (If there's any outside code calling GetVirtualXIDsDelayingChkpt, which it seems like there might be.) regards, tom lane