On 12.05.22 21:30, Andres Freund wrote:
On 2022-05-11 12:18:58 +0200, Peter Eisentraut wrote:
I fixed the Perl detection issue in my macOS environment that I had reported
a while ago.
Hm. I wonder if it's right to check with is_file() - perhaps there are
platforms that have split off the include directory?
The existing code uses "test -f", so using is_file() would keep it
working the same way.
After that, these configure options don't have an equivalent yet:
--disable-rpath
--enable-profiling
--disable-thread-safety
--with-libedit-preferred
The first three overlap with meson built-in functionality, so we would need
to check whether the desired functionality is available somehow.
Which builtin functionality does --enable-profiling overlap with? There's a
coverage option, perhaps you were thinking of that?
I saw an option about "profile guided optimization" (b_pgo), which seems
possibly related.
I don't think we should add --disable-thread-safety, platforms without it also
aren't going to support ninja / meson... IIRC Thomas was planning to submit a
patch getting rid of it independently...
sure
From 049b34b6a8dd949f0eb7987cad65f6682a6ec786 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <pe...@eisentraut.org>
Date: Wed, 11 May 2022 09:06:13 +0200
Subject: [PATCH 3/9] meson: prereq: Refactor dtrace postprocessing make rules
Move the dtrace postprocessing sed commands into a separate file so
that it can be shared by meson. Also split the rule into two for
proper dependency declaration.
Hm. Using sed may be problematic on windows...
This code is only used when dtrace is enabled, which probably doesn't
apply on Windows.
