I looked at some of the "prereq" patches again to see what state they
are in:
commit 351a12f48e395b31cce4aca239b934174b36ea9d
Author: Andres Freund <and...@anarazel.de>
Date: Wed Apr 20 22:46:54 2022
prereq: deal with \ paths in basebackup_to_shell tests.
This is a new component in PG15, so a fix might be in scope for PG15
too. But I don't know if this change is really necessary. There are
other tests that use the GZIP and TAR environment variables (e.g.,
pg_verifybackup). If this is a problem there too, we should think of a
general solution. If not, it could use some explanation.
commit c00642483a53f4ee6e351085c7628363c293ee61
Author: Andres Freund <and...@anarazel.de>
Date: Fri Mar 25 21:44:48 2022
meson: prereq: unicode: allow to specify output directory.
OK with attached fixup (but see below).
commit 31313056e153e099f236a29b752f7610c4f7764f
Author: Andres Freund <and...@anarazel.de>
Date: Thu Jan 20 08:36:50 2022
meson: prereq: generate-errcodes.pl: accept output file
This is ok, but seems unnecessary, since meson can capture the output of
a single file. (See also similar script generate-errcodes-table.pl in
doc/, which uses capture.)
commit e4e77c0e20f3532be4ed270a7cf8b965b7cafa49
Author: Andres Freund <and...@anarazel.de>
Date: Thu Jan 20 08:36:50 2022
meson: prereq: add output path arg in generate-lwlocknames.pl
We should make the command-line interface here the same as the unicode
script: Either make the output directory a positional argument or an
option. I don't have a strong feeling about it either way, but perhaps
the solution with the option is more elegant and would also not require
changing the makefiles. Also, we should decide on short or long option:
The code declares a long option, but the build uses a short option.
It's confusing that that even works.
commit 7866620afa65223f6e657da972f501615fd32d3b
Author: Andres Freund <and...@anarazel.de>
Date: Wed Apr 20 21:01:31 2022
meson: prereq: output and depencency tracking work.
This could be split into multiple parts with more detailed explanations.
I see where you're going but not everything is fully clear to me
(especially the guc-file.c.h stuff).From 51c6d3544ae9e652c7aac26102a8bf5a116fb182 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <pe...@eisentraut.org>
Date: Tue, 7 Jun 2022 22:54:26 +0200
Subject: [PATCH] fixup! meson: prereq: unicode: allow to specify output
directory.
---
src/common/unicode/generate-unicode_norm_table.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/common/unicode/generate-unicode_norm_table.pl
b/src/common/unicode/generate-unicode_norm_table.pl
index 3d0c3f0ebc..ed4181fce6 100644
--- a/src/common/unicode/generate-unicode_norm_table.pl
+++ b/src/common/unicode/generate-unicode_norm_table.pl
@@ -40,7 +40,7 @@
my @characters = ();
my %character_hash = ();
open($FH, '<', "$directory/UnicodeData.txt")
- or die "Could not open UnicodeData.txt: $!.";
+ or die "Could not open $directory/UnicodeData.txt: $!.";
while (my $line = <$FH>)
{
--
2.36.1
