On Wed, 20 Jul 2022 at 15:22, Thomas Munro <thomas.mu...@gmail.com> wrote: > Ok, I've pushed the Windows patch. I'll watch the build farm to see > if I've broken any of the frankentoolchain Windows animals.
Just to get in there before the farm does... I just got a boatload of redefinition of HAVE_FDATASYNC warnings. I see it already gets defined in pg_config.h All compiles cleanly with the attached. David
diff --git a/src/include/port/win32_port.h b/src/include/port/win32_port.h index 5ea66528fa..4de5bf3bf6 100644 --- a/src/include/port/win32_port.h +++ b/src/include/port/win32_port.h @@ -87,7 +87,9 @@ * We have a replacement for fdatasync() in src/port/fdatasync.c, which is * unconditionally used by MSVC and Mingw builds. */ +#ifndef HAVE_FDATASYNC #define HAVE_FDATASYNC +#endif #define USES_WINSOCK
