On 7/22/22 10:58, Pavel Stehule wrote:
čt 21. 7. 2022 v 9:34 odesílatel Julien Rouhaud <[email protected]
<mailto:[email protected]>> napsal:
> [v20220722] patches
Hi Pavel,
Thanks, docs now build.
Attached a few small text-changes.
Also, the pg_restore-doc still has the old name 'schema_variable'
instead of session_variable:
-A schema_variable
--variable=schema_variable
Surely those should be changed as well.
Erik Rijkers
--- ./doc/src/sgml/ref/alter_variable.sgml.orig 2022-07-22 12:18:47.905664314 +0200
+++ ./doc/src/sgml/ref/alter_variable.sgml 2022-07-22 12:34:52.928275143 +0200
@@ -28,7 +28,7 @@
<refsynopsisdiv>
<synopsis>
-ALTER VARIABLE <replaceable class="parameter">name</replaceable> OWNER TO { <replaceable class="parameter">new_owner</replaceable> | CURRENT_USER | SESSION_USER }
+ALTER VARIABLE <replaceable class="parameter">name</replaceable> OWNER TO { <replaceable class="parameter">new_owner</replaceable> | CURRENT_ROLE | CURRENT_USER | SESSION_USER }
ALTER VARIABLE <replaceable class="parameter">name</replaceable> RENAME TO <replaceable class="parameter">new_name</replaceable>
ALTER VARIABLE <replaceable class="parameter">name</replaceable> SET SCHEMA <replaceable class="parameter">new_schema</replaceable>
</synopsis>
--- ./doc/src/sgml/ref/create_variable.sgml.orig 2022-07-22 12:18:13.877300499 +0200
+++ ./doc/src/sgml/ref/create_variable.sgml 2022-07-24 14:52:50.587010931 +0200
@@ -58,10 +58,10 @@
<note>
<para>
Inside a query or an expression, the session variable can be shadowed by
- column or by routine's variable or routine argument. The collision of
- identifiers can be solved by using qualified identifiers. Session variables
- can use schema name, columns can use table aliases, routine's variables
- can use block's labels, and routine's arguments can use routine name.
+ column or by routine's variable or routine argument. Such collisions of
+ identifiers can be resolved by using qualified identifiers. Session variables
+ can use schema name, columns can use table aliases, routine variables
+ can use block labels, and routine arguments can use the routine name.
</para>
</note>
</refsect1>
@@ -74,21 +74,16 @@
<term><literal>IMMUTABLE</literal></term>
<listitem>
<para>
- The assigned value of the session variable can never be changed.
- If the session variable doesn't have a default value, then a single
+ The assigned value of the session variable can not be changed.
+ Only if the session variable doesn't have a default value, a single
initialization is allowed using the <command>LET</command> command. Once
- done, no other change will be allowed until end of transcation
- (when session variable was created with clause <literal>ON TRANSACTION
- END RESET</literal> or until reset of all session variables by
- <command>DISCARD VARIABLES</command> or until reset of all session
+ done, no further change is allowed until end of transaction
+ if the session variable was created with clause <literal>ON TRANSACTION
+ END RESET</literal>, or until reset of all session variables by
+ <command>DISCARD VARIABLES</command>, or until reset of all session
objects by command <command>DISCARD ALL</command>.
</para>
- <para>
- When <literal>IMMUTABLE</literal> session variable has assigned
- default value by using <literal>DEFAULT expr</literal> clause, then
- the value of session variable cannot be changed ever.
- </para>
</listitem>
</varlistentry>
@@ -152,7 +147,7 @@
<para>
The <literal>DEFAULT</literal> clause can be used to assign a default
value to a session variable. This expression is evaluated when the session
- variable is accessed for reading first time, and had not assigned any value.
+ variable is first accessed for reading and had not yet been assigned a value.
</para>
</listitem>
</varlistentry>
--- ./doc/src/sgml/ref/let.sgml.orig 2022-07-22 12:04:25.096021723 +0200
+++ ./doc/src/sgml/ref/let.sgml 2022-07-24 15:05:39.038636565 +0200
@@ -58,7 +58,7 @@
<term><literal>sql_expression</literal></term>
<listitem>
<para>
- An SQL expression. The result is cast to the data type of the session
+ An SQL expression, in parentheses. The result must be of the same data type as the session
variable.
</para>
</listitem>
@@ -69,7 +69,7 @@
<listitem>
<para>
Reset the session variable to its default value, if that is defined.
- If no explicit default value has been assigned, the session variable
+ If no explicit default value has been declared, the session variable
is set to NULL.
</para>
</listitem>