Hi, On 2022-08-17 08:25:06 -0400, Robert Haas wrote: > Regarding the question of whether we need a cleanup lock on the new > bucket I am not really seeing the advantage of going down that path. > Simply fixing this code to take a cleanup lock instead of hoping that > it always gets one by accident is low risk and should fix the observed > problem. Getting rid of the cleanup lock will be more invasive and I'd > like to see some evidence that it's a necessary step before we take > the risk of breaking things.
Given that the cleanup locks in question are "taken" *after* re-initializing the page, I'm doubtful that's a sane path forward. It seems quite likely to mislead somebody to rely on it working as a cleanup lock in the future. Greetings, Andres Freund
