Hi, On 2022-08-17 15:21:55 -0400, Robert Haas wrote: > On Wed, Aug 17, 2022 at 2:45 PM Andres Freund <and...@anarazel.de> wrote: > > Given that the cleanup locks in question are "taken" *after* re-initializing > > the page, I'm doubtful that's a sane path forward. It seems quite likely to > > mislead somebody to rely on it working as a cleanup lock in the future. > > There's not a horde of people lining up to work on the hash index > code, but if you feel like writing and testing the more invasive fix, > I'm not really going to fight you over it.
My problem is that the code right now is an outright lie. At the absolute very least this code needs a big honking "we check if we have a cleanup lock here, but that's just for show, because WE ALREADY OVERWROTE THE WHOLE PAGE". Greetings, Andres Freund
