Hi, On 2022-08-17 14:53:17 -0700, Andres Freund wrote: > > - In the top-level meson.build, the "renaming" of the Windows system > > name > > > > host_system = host_machine.system() == 'windows' ? 'win32' : > > host_machine.system() > > build_system = build_machine.system() == 'windows' ? 'win32' : > > build_machine.system() > > > > seems unnecessary to me. Why not stick with the provided names? > > Because right now we also use it for things like choosing the "source" for > pg_config_os.h (i.e. include/port/{darwin,linux,win32,..}.h). And it seemed > easier to just have one variable name for all of it.
I am now changing this so that there's an additional 'portname' variable for this purpose. Otherwise the meson names are used. Greetings, Andres Freund