On Fri, Oct 7, 2022 at 7:25 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > Thanks for updating the patch! LGTM.
- if (!am_walsender) + if (!am_walsender || am_db_walsender) appendStringInfo(&ps_data, "%s ", port->database_name); Can the appendStringInfo be just unconditional? That is more readable IMO. We want the database_name to be appended whenever it isn't null. The only case we expect database_name to be null is for walsenders serving streaming replication standbys and even when database_name is null, nothing gets appended, it's just the appendStringInfo() call gets wasted, but that's okay. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com