Michael Paquier <mich...@paquier.xyz> writes:
> I am wondering if it would be worth adding an AssertMacro() like in
> this one, though:
> https://www.postgresql.org/message-id/ykap64jvztmgc...@paquier.xyz
Kind of doubt it. It'd bloat debug builds with a lot of redundant
checks, and probably never catch anything. For catching problems
in production, the right place to do this (and where we already do
do it) is in _bt_checkpage.
If any of the other AMs lack page-read-time sanity checks like
_bt_checkpage, I'd be in favor of adding that. But I don't
think a whole bunch of additional checks afterwards will buy much.
regards, tom lane
