Hi, On 2022-12-08 17:57:09 -0500, Tom Lane wrote: > Given that this additional experimentation didn't find any holes > in the API design, I think this is pretty much ready to go.
One interesting area is timestamp / datetime related code. There's been some past efforts in the area, mostly in 5bc450629b3. See the RETURN_ERROR macro in formatting.c. This is not directly about type input functions, but it looks to me that the functionality in the patchset should work. I certainly have the hope that it'll make the code look a bit less ugly... It looks like a fair bit of work to convert this code, so I don't think we should tie converting formatting.c to the patchset. But it might be a good idea for Tom to skim the code to see whether there's any things impacting the design. Greetings, Andres Freund
