Hi On 2023-02-15 10:28:37 +0900, Kyotaro Horiguchi wrote: > At Tue, 14 Feb 2023 16:55:25 -0800, Andres Freund <and...@anarazel.de> wrote > in > > Hi, > > > > On 2023-02-14 18:00:00 +0530, Bharath Rupireddy wrote: > > > Done, PSA v2 patch. > > > > This feels way too complicated to me. How about something more like the > > attached? > > I like this one, but the parameters offset and size are in a different > order from pwrite(fd, buf, count, offset). I perfer the arrangement > suggested by Bharath.
Yes, it probably is better. Not sure why I went with that order. > And isn't it better to use Min(remaining_size, BLCKSZ) instead of a bare if > statement? I really can't make myself care about which version is better :) Greetings, Andres Freund
