On Thu, Mar 9, 2023 at 6:34 AM Peter Smith <smithpb2...@gmail.com> wrote: > > 4. build_replindex_scan_key > > > > > Based on the discussions below, I kept as-is. I really don't want to do > > unrelated > > changes in this patch, as I also got several feedback for not doing it, > > > > Hmm, although this code pre-existed I don’t consider this one as > "unrelated changes" because the patch introduced the new "if > (!AttributeNumberIsValid(table_attno))" which changed things. As I > wrote to Amit yesterday [2] IMO it would be better to do the 'opttype' > assignment *after* the potential 'continue' otherwise there is every > chance that the assignment is just redundant. And if you move the > assignment where it belongs, then you might as well declare the > variable in the more appropriate place at the same time – i.e. with > 'opfamily' declaration. Anyway, I've given my reason a couple of times > now, so if you don't want to change it I won't about it debate > anymore. >
I agree with this reasoning. -- With Regards, Amit Kapila.
