On Mon, Apr 10, 2023 at 9:15 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Sat, Apr 8, 2023 at 1:35 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > Do we need to have a check for this new option "password_required" in > > maybe_reread_subscription() where we "Exit if any parameter that > > affects the remote connection was changed."? This new option is > > related to the remote connection so I thought it is worth considering > > whether we want to exit and restart the apply worker when this option > > is changed. > > Hmm, good question. I think that's probably a good idea. If the > current connection is already working, the only possible result of > getting rid of it and trying to create a new one is that it might now > fail instead, but someone might want that behavior. Otherwise, they'd > instead find the failure at a later, maybe less convenient, time. >
I think additionally, we should check that the new owner of the subscription is not a superuser, otherwise, anyway, this parameter is ignored. Please find the attached to add this check. -- With Regards, Amit Kapila.
exit_on_sub_opt_change_1.patch
Description: Binary data
