On Tue, Apr 11, 2023 at 8:21 PM Robert Haas <robertmh...@gmail.com> wrote: > > On Tue, Apr 11, 2023 at 5:53 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > I think additionally, we should check that the new owner of the > > subscription is not a superuser, otherwise, anyway, this parameter is > > ignored. Please find the attached to add this check. > > I don't see why we should check that. It makes this different from all > the other cases and I don't see any benefit. >
I thought it would be better if we don't restart the worker unless it is required. In case, the subscription's owner is a superuser, the 'password_required' is ignored, so why restart the apply worker when somebody changes it in such a case? I understand that there may not be a need to change the 'password_required' option when the subscription's owner is the superuser but one may first choose to change the password_required flag and then the owner of a subscription to a non-superuser. Anyway, I don't think as such there is any problem with restarting the worker even when the subscription owner is a superuser, so adjusted the check accordingly. -- With Regards, Amit Kapila.
exit_on_sub_opt_change_2.patch
Description: Binary data
