On Sun, May 21, 2023 at 01:20:01PM -0400, Tom Lane wrote: > Nathan Bossart <nathandboss...@gmail.com> writes: >> Fixed. > > v2 looks good to me, except the documentation wording for --with-role > is needlessly inconsistent with --with-admin. The --with-admin > wording looks better, so I suggest > > - Indicates the specified existing role should be automatically > + Specifies an existing role that will be automatically > added as a member of the new role. Multiple existing roles can
Will do. >> How do folks feel about keeping --role undocumented? Should we give it a >> mention in the docs for --member-of? > > I'm okay with leaving it undocumented, but I won't fight about it > if somebody wants to argue for the other. Alright. Barring any additional feedback, I'll commit this tonight. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
