On 22.06.23 21:08, David Zhang wrote:
Currently, there is a description suggesting a workaround by running a 'make install' command first, but I find it to be somewhat inaccurate. It would be better to update the existing description to provide more precise instructions on how to overcome this issue. Here are the changes I would suggest.

from:
"You can work around that by doing make install before make check. Most PostgreSQL developers just turn off SIP, though."

to:
"You can execute sudo make install if you do not specify a prefix during the configure step, or make install without sudo if you do specify a prefix (assuming proper permissions) before make check. Most PostgreSQL developers just turn off SIP, though."

Otherwise, following the current description, if you run `./configure && make install` you will get error: "mkdir: /usr/local/pgsql: Permission denied"

I think you should interpret "doing make install" as "running make install or a similar command as described earlier in this chapter". Note also that the installation instructions don't use "sudo" anywhere right now, so throwing it in at this point would be weird.

echo "# +++ tap check in src/test/modules/brin +++"
... ...
# +++ tap check in src/test/modules/brin +++
t/01_workitems.pl ........ Bailout called.  Further testing stopped: command "initdb -D /Users/david/hg/sandbox/postgres/src/test/modules/brin/tmp_check/t_01_workitems_tango_data/pgdata -A trust -N" died with signal 6
t/01_workitems.pl ........ Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run

As I mentioned earlier, you would need to find all uses of system() in the PostgreSQL source code and make your adjustments there. IIRC, the TAP tests require pg_ctl, so maybe look there.


Reply via email to