On Wed, Oct 11, 2023 at 7:53 AM Heikki Linnakangas <hlinn...@iki.fi> wrote: > > + * Buffer must be pinned and exclusive-locked. (If caller does not hold > > + * exclusive lock, then the result may be stale before it's returned.) > The comment suggests that you don't need to hold an exclusive lock when > you call this, but there's an assertion that you do.
I don't think the comment suggests that. It would if you only read the sentence in parentheses. But if you read both of them it seems clear enough. I guess the parenthetical sentence cloud say "If the caller did not hold an exclusive lock, then the result might become stale even before it was returned," basically putting the whole thing in the subjunctive. -- Robert Haas EDB: http://www.enterprisedb.com