Dear Horiguchi-san, Shlok, > > At Fri, 6 Oct 2023 12:28:32 +0530, Shlok Kyal <shlok.kyal....@gmail.com> wrote > i> D:\project\pg_dev\bin>pg_ctl -D ../data -l data2.log start > > pg_ctl: another server might be running; trying to start server anyway > > waiting for server to start....pg_ctl: launcher shell died > > > > The output message after patch is different from the HEAD. I felt that > > with patch as well we should get the message "pg_ctl: could not start > > server". > > Is this message change intentional? > > Partly no, partly yes. My focus was on verifying the accuracy of > identifying the actual postmaster PID on Windows. The current patch > provides a detailed description of the events, primarily because I > lack a comprehensive understanding of both the behavior of Windows > APIs and the associated processes. Given that context, the messages > essentially serve debugging purposes. > > I agree with your suggestion. Ultimately, if there's a possibility > for this to be committed, the message will be consolidated to "could > not start server".
Based on the suggestion, I tried to update the patch. A new argument is_valid is added for reporting callee. Also, reporting formats are adjusted based on other functions. How do you think? Best Regards, Hayato Kuroda FUJITSU LIMITED
v3-0001-Disable-autoruns-for-cmd.exe-on-Windows.patch
Description: v3-0001-Disable-autoruns-for-cmd.exe-on-Windows.patch
v3-0002-Improve-pg_ctl-postmaster-process-check-on-Window.patch
Description: v3-0002-Improve-pg_ctl-postmaster-process-check-on-Window.patch
v3-0003-Remove-short-sleep-from-001_start_stop.pl.patch
Description: v3-0003-Remove-short-sleep-from-001_start_stop.pl.patch
