On Fri, Oct 27, 2023 at 5:45 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Thu, Oct 26, 2023 at 09:40:09AM -0400, Robert Haas wrote: > > Because of this, it is possible for bucketbuf, prevbuf, and wbuf to be > > the same (your first scenario) but the second scenario you mention > > (nextbuf == wbuf) should be impossible. > > Okay.. > > > It seems to me that maybe we shouldn't even be registering wbuf or > > doing anything at all to it if there are no tuples that need moving. > > That would also require some adjustment of the redo routine. > > Hmm. So my question is: do we need the cleanup lock on the write > buffer even if there are no tuples, and even if primary bucket and the > write bucket are the same? >
Yes, we need it to exclude any concurrent in-progress scans that could return incorrect tuples during bucket squeeze operation. -- With Regards, Amit Kapila.
