On 24.11.2023 13:20, Alena Rybakina wrote:

Hi! Thank you for your work on the subject, I think it's a really useful feature.

I've reviewed your patch and I have a few questions.

First of all, have you thought about creating a gun parameter to display memory scheduling information? I agree that this is an important feature, but I think only for debugging.

Secondly, I noticed that for the child_rinfo_hash key you use a counter (int) and can it lead to collisions? Why didn't you generate a hash from childRestrictInfo for this? For example, something like how it is formed here [0].

[0] https://www.postgresql.org/message-id/43ad8a48-b980-410d-a83c-5beebf82a4ed%40postgrespro.ru

Sorry, my first question was not clear, I mean: have you thought about creating a guc parameter to display memory planning information?

--
Regards,
Alena Rybakina

Reply via email to