Re: Refactoring backend fork+exec code

[reid . thompson]

On Thu, 2024-01-25 at 01:51 +0200, Heikki Linnakangas wrote:
> 
> And here we go. BackendID is now a 1-based index directly into the 
> PGPROC array.
> 

Would it be worthwhile to also note in this comment FIRST_AUX_PROC's
and IsAuxProcess()'s dependency on B_ARCHIVER and it's location in the
enum table?

      /*                                                                        
                                                      
      ¦* Auxiliary processes. These have PGPROC entries, but they are not       
                                                      
      ¦* attached to any particular database. There can be only one of each of  
                                                      
      ¦* these running at a time.                                               
                                                      
      ¦*                                                                        
                                                      
      ¦* If you modify these, make sure to update NUM_AUXILIARY_PROCS and the   
                                                      
      ¦* glossary in the docs.                                                  
                                                      
      ¦*/                                                                       
                                                      
      B_ARCHIVER,                                                               
                                                      
      B_BG_WRITER,                                                              
                                                      
      B_CHECKPOINTER,                                                           
                                                      
      B_STARTUP,                                                                
                                                      
      B_WAL_RECEIVER,                                                           
                                                      
      B_WAL_SUMMARIZER,                                                         
                                                      
      B_WAL_WRITER,                                                             
                                                      
  } BackendType;                                                                
                                                      
                                                                                
                                                    
  #define BACKEND_NUM_TYPES (B_WAL_WRITER + 1)                        
                                                                                
                                                      
  extern PGDLLIMPORT BackendType MyBackendType;                       
                                                                                
                                                      
  #define FIRST_AUX_PROC B_ARCHIVER                                   
  #define IsAuxProcess(type)          (MyBackendType >= FIRST_AUX_PROC)