On June 21, 2018 9:04:28 AM PDT, Tom Lane <t...@sss.pgh.pa.us> wrote: >Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >> Patch after pgindent attached. This will involve a catversion bump >since >> we're adding a new function. > >This isn't really ready to go. One clear problem is that you broke >pg_dump'ing from any pre-v11 version, because you did not add suitable >null outputs to the pre-v11 query variants in getTableAttrs. Thought the same for a bit - think it's OK though, because there a check for PQfnumber being bigger than 0... Andres -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
- Re: Fast default stuff versus pg_upgrade Andres Freund
- Re: Fast default stuff versus pg_upgrade Andrew Dunstan
- Re: Fast default stuff versus pg_upgrade Andres Freund
- Re: Fast default stuff versus pg_upgrade Andrew Dunstan
- Re: Fast default stuff versus pg_upgrade Andrew Dunstan
- Re: Fast default stuff versus pg_upgrade Andres Freund
- Re: Fast default stuff versus pg_upgrade Andrew Dunstan
- Re: Fast default stuff versus pg_upgrade Tom Lane
- Re: Fast default stuff versus pg_upgrade Tom Lane
- Re: Fast default stuff versus pg_upgrade Andrew Dunstan
- Re: Fast default stuff versus pg_upgrade Andres Freund
- Re: Fast default stuff versus pg_upgrade Tom Lane
- Re: Fast default stuff versus pg_upgrade Andrew Dunstan
- Re: Fast default stuff versus pg_upgrade Tom Lane
- Re: Fast default stuff versus pg_upgrade Andrew Dunstan
- Re: Fast default stuff versus pg_upgrade Andres Freund
- Re: Fast default stuff versus pg_upgrade Tom Lane
- Re: Fast default stuff versus pg_upgrade Andres Freund
- Re: Fast default stuff versus pg_upgrade Tom Lane
- Re: Fast default stuff versus pg_upgrade Andrew Dunstan
- Re: Fast default stuff versus pg_upgrade Tom Lane