On Tue, Mar 12, 2024 at 12:22 PM Michael Paquier <mich...@paquier.xyz> wrote: > > On Mon, Mar 11, 2024 at 06:00:00PM +0530, Bharath Rupireddy wrote: > > Please see the attached v6 patch set. > > I am tempted to tweak a few things in the docs, the comments and the > tests (particularly adding more patterns for tuples that fail on > conversion while it's clear that there are not enough attributes after > the incorrect values), but that looks roughly OK.
+1. But, do you want to add them now or later as a separate patch/discussion altogether? > Wouldn't it be better to squash the patches together, by the way? I guess not. They are two different things IMV. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
