On Wed, Oct 30, 2024 at 07:26:07AM +0000, Bertrand Drouvot wrote: > 1 === Nit > > s/Permutations like this one/Permutations like the following commented out > one/ ? > > 2 === > > s/back its result/back its result once woken up/ ? > > 3 === > > s/faster than the wait/before the SQL function doing the wait returns its > result/ ? > > With 2 === and 3 === I think it's easier to "link" both sentences that way.
What do you think about the updated version attached? -- Michael
diff --git a/src/test/modules/injection_points/specs/basic.spec b/src/test/modules/injection_points/specs/basic.spec
index 7f44e3ddc3..47db676c0c 100644
--- a/src/test/modules/injection_points/specs/basic.spec
+++ b/src/test/modules/injection_points/specs/basic.spec
@@ -26,7 +26,10 @@ step wakeup2 { SELECT injection_points_wakeup('injection-points-wait'); }
step detach2 { SELECT injection_points_detach('injection-points-wait'); }
# Detach after wait and wakeup.
-# This permutation is proving to be unstable on FreeBSD, so disable for now.
+# Permutations like the following one commented out should be avoided, as
+# the detach may finish before the SQL function doing the wait returns
+# its result. It is recommended to use wakeups as the last permutation
+# should a wait be done within an SQL function.
#permutation wait1 wakeup2 detach2
# Detach before wakeup. s1 waits until wakeup, ignores the detach.
signature.asc
Description: PGP signature
