On 07.11.24 19:38, Alvaro Herrera wrote:
I have just noticed that since this patch was committed as 04bec894a04c, pg_upgrade's "make check" action is unusable when given the "olddump/oldinstall" options. We now need to inject '-k' to the initdb line for old servers, and we don't, so all upgrade tests fail. I think this patch should be enough to fix it.
Yes, this fix looks correct. (Or the other way around: Disable checksums on the new node.)
Is this not being covered by the build farm? Are the upgrade tests there not using this?