On 2024-Nov-13, Peter Eisentraut wrote: > On 07.11.24 19:38, Alvaro Herrera wrote: > > I have just noticed that since this patch was committed as 04bec894a04c, > > pg_upgrade's "make check" action is unusable when given the > > "olddump/oldinstall" options. We now need to inject '-k' to the initdb > > line for old servers, and we don't, so all upgrade tests fail. I think > > this patch should be enough to fix it. > > Yes, this fix looks correct.
Thanks, pushed. > (Or the other way around: Disable checksums on the new node.) Yeah, I thought about that too, but, I think it'd be less realistic, because the world is become one where checksums are enabled, not the other way around. > Is this not being covered by the build farm? Are the upgrade tests there > not using this? Nope, the buildfarm has separate code to test cross-version upgrades, https://github.com/PGBuildFarm/client-code/blob/main/PGBuild/Modules/TestUpgradeXversion.pm This predates our in-core test support. Maybe buildfarm's could be simplified, but I'm not sure if it's worth it. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "El sentido de las cosas no viene de las cosas, sino de las inteligencias que las aplican a sus problemas diarios en busca del progreso." (Ernesto Hernández-Novich)
