On Tue, Dec 3, 2024 at 7:06 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > This is from hake[1], which is running OpenIndiana/illumos. > That platform shows a couple of other strange warnings, so maybe > re-eliminating these two is not worth worrying about, but > nonetheless the casts to void * were doing something here.
I wouldn't change that. illumos is selecting the old pre-standard declaration here, but it knows the standard one: https://github.com/illumos/illumos-gate/blob/27ecbff00d8c86a2647d6fe325cacb220d712115/usr/src/uts/common/sys/shm.h#L129 https://illumos.org/man/2/shmdt I don't know why we have only one tiny issue if the system headers think we want pre-POSIX stuff. I wonder if the particular header has incorrect guarding, but I don't know how that is supposed to work.
