Hello
Thank you for review!
Well, i can miss some cases. I'm not sure about overall design of this patch. 
Is acceptable add errdetail_params to statement_timeout ereport in such way?

After shutdown signal we must be in aborted state, so we mustn't call 
user-defined I/O functions. (quotation from comment to errdetail_params in 
src/backend/tcop/postgres.c ). It seems i can not fix it with current design.

> ERROR:  canceling statement due to lock timeout at character 13
Hm, "at character"? How can we get this message? I found only "canceling 
statement due to lock timeout" (without "at character") ereport in 
src/backend/tcop/postgres.c
Maybe try .. catch in parse state, not in execute?

regards, Sergei

Reply via email to