Hello Thank you for update! I did only quick test now: patch applied and build clean. But i have reproducible error during check-world:
> t/001_standby_checksum.pl .. 6/10 > # Failed test 'ensure checksums are enabled on standby' > # at t/001_standby_checksum.pl line 84. > # got: 'inprogress' > # expected: 'on' In stanby log i found error: > 2018-07-25 13:13:05.463 MSK [16544] FATAL: could not receive data from WAL > stream: ERROR: requested WAL segment 000000010000000000000003 has already > been removed Checksumhelper obviously writes lot of wal. Test pass if i change restart order to slave first: > $node_standby_1->restart(); > $node_master->restart(); Or we need replication slot setup. Also we have log record after start: > data checksums in pending state, starting background worker to enable even in recovery state with actual start background worker only at recovery end (or promote). I think better using DEBUG ereport in postmaster and LOG in checksumhelper. regards, Sergei 25.07.2018, 12:35, "Daniel Gustafsson" <dan...@yesql.se>: >> On 24 Jul 2018, at 11:05, Sergei Kornilov <s...@zsrv.org> wrote: >> >> The following review has been posted through the commitfest application: >> make installcheck-world: tested, failed >> Implements feature: not tested >> Spec compliant: not tested >> Documentation: tested, failed >> >> Hello >> As i wrote few weeks ago i can not build documentation due errors: >>> postgres.sgml:19625: element xref: validity error : IDREF attribute >>> linkend references an unknown ID "runtime-checksumhelper-cost-delay" >>> postgres.sgml:19626: element xref: validity error : IDREF attribute >>> linkend references an unknown ID "runtime-checksumhelper-cost-limit" >> >> After remove such xref for test purposes patch pass check-world. > > Hi!, > > Thanks for reviewing, I’ve updated the patch with the above mentioned > incorrect > linkends as well as fixed the comments you made in a previous review. > > The CF-builder-bot is red, but it’s because it’s trying to apply the already > committed patch which is in the attached datallowconn thread. > > cheers ./daniel
