On Wed, Jul 25, 2018 at 11:35:31AM +0200, Daniel Gustafsson wrote: > > On 24 Jul 2018, at 11:05, Sergei Kornilov <s...@zsrv.org> wrote: > > > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, failed > > Implements feature: not tested > > Spec compliant: not tested > > Documentation: tested, failed > > > > Hello > > As i wrote few weeks ago i can not build documentation due errors: > >> postgres.sgml:19625: element xref: validity error : IDREF attribute > >> linkend references an unknown ID "runtime-checksumhelper-cost-delay" > >> postgres.sgml:19626: element xref: validity error : IDREF attribute > >> linkend references an unknown ID "runtime-checksumhelper-cost-limit" > > > > After remove such xref for test purposes patch pass check-world. > > Hi!, > > Thanks for reviewing, I’ve updated the patch with the above mentioned > incorrect > linkends as well as fixed the comments you made in a previous review. > > The CF-builder-bot is red, but it’s because it’s trying to apply the already > committed patch which is in the attached datallowconn thread.
I think checksumhelper_cost_delay should be checksum_helper_cost_delay. ^ Is "helper" the right word? -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +