On 2018-Jul-25, Andres Freund wrote: > On 2018-07-25 18:11:13 -0400, Alvaro Herrera wrote: > > On 2018-Jul-25, Andres Freund wrote:
> > But what would be the advantage of avoiding the context release inside > > FreeExecutorState? It seems pretty appropriate to me to do it there. > > You could argue that the JIT context is definitely part of the estate > > being freed. Just amend the comment, no? > > I agree it's right to do it there. Ok. > I think I'm more questioning whether there's even a need to adapt the > comment, given it's really a local memory resource. But I guess I'll > just add a 'and ...' after "ExprContexts within the EState". Yeah, adding two words there sounds good. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
