On 2018-07-25 18:59:51 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > On 2018-07-25 18:11:13 -0400, Alvaro Herrera wrote: > >> But what would be the advantage of avoiding the context release inside > >> FreeExecutorState? It seems pretty appropriate to me to do it there. > >> You could argue that the JIT context is definitely part of the estate > >> being freed. Just amend the comment, no? > > > I agree it's right to do it there. I think I'm more questioning whether > > there's even a need to adapt the comment, given it's really a local > > memory resource. But I guess I'll just add a 'and ...' after > > "ExprContexts within the EState". > > +1. Clarity is good.
Pushed something along those lines. Thanks again Dmitry for reporting the issue! - Andres
