On Mon, Mar 24, 2025 at 06:47:59PM -0500, Sami Imseih wrote: > I know it was mentioned above by both Michael and Andrei that > AppendJumble should not be exposed. I am not sure I agree with > that. I think it should be exposed, along with > JUMBLE_FIELD, JUMBLE_FIELD_SINGLE and JUMBLE_STRING > and _jumbleList. > > I am afraid that if we don't expose these routines/macros, the > extension will have > to re-invent those wheels. This is not included in v1-0001, but If > there is no objection, > I can update the patch. Thoughts?
Hmm, yes, the macros could prove to be useful to allow extensions to compile their own code the manipulations they want to do on the node structures they'd like to touch, but wouldn't that mean that they would copy in some way a portion of what gen_node_support.pl does? Perhaps we should think more carefully about this part, and refactor this script to work as a perl module so as it could be reused by some external code, at least for the parsing of the headers and the attributes assigned to each nodes and their attributes? This is just to drop an idea in the bucket of ideas, trying to think about the potential larger picture. -- Michael
signature.asc
Description: PGP signature