> I reviewed the patch and I only have one comment. I still think > we need an Assert inside RecordConstantLocation to make sure clocations > is allocated if the caller intends to record constant locations. > > RecordConstLocation(JumbleState *jstate, int location, bool squashed) > { > + Assert(jstate->clocations); > +
Here is v3 with the Assert in place -- Sami Imseih Amazon Web Services (AWS)
v3-0001-Allow-plugins-to-Jumble-an-expression.patch
Description: Binary data