On Tue, Mar 25, 2025 at 5:15 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Mar 25, 2025 at 5:08 PM Ashutosh Bapat > <ashutosh.bapat....@gmail.com> wrote: > > > > This looks mostly ready except the test changes. I believe when > > committing, we are going to squash all three into a single commit. Is > > that correct? > > > > I would not prefer to commit 0003 as it is primarily because of test > +# run pg_createsubscriber with '--all' option without '--dry-run'. I > am not so sure whether it is really worth adding test cycles for this > option except for dry-run mode tests but we can discuss after > committing the core patch.
I am worried that without that test, we won't catch bugs in creating slots, publications and subscriptions and thus causing problems in a setup with --all. But as long as we address that concern I am ok to defer it after committing the core patch. -- Best Wishes, Ashutosh Bapat
