On Thu, Mar 27, 2025 at 12:16 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Mar 26, 2025 at 4:02 PM Shubham Khanna > <khannashubham1...@gmail.com> wrote: > > > > Let's combine 0001 and 0002. >
Combined 0001 and 0002. > A few minor comments: > * > + If database name is not specified in publisher-server, it will try to > + connect with postgres/template1 database to fetch the databases from > + primary. > > Can we change the above to: "If the database name is not specified in > publisher-server, the postgres database will be used, or if that does > not exist, template1 will be used." > Fixed. > * > + Create one subscription on the target server for each non-template > + database on the source server that allows connections, excluding > + template databases or databases with connection restrictions. > > The following text proposed by Euler seems better: "Create one > subscription per database on the target server. Exceptions are > template databases and databases that don't allow connections." > > Please use this one at the above and other places where required. > Fixed. The attached patches contain the suggested changes. They also address the comments provided by Kuroda-san (at [1]). [1] - https://www.postgresql.org/message-id/OSCPR01MB149660B6D00665F47896CA812F5A12%40OSCPR01MB14966.jpnprd01.prod.outlook.com Thanks and regards, Shubham Khanna.
v23-0001-Enhance-pg_createsubscriber-to-fetch-and-append-.patch
Description: Binary data
v23-0002-Synopsis-for-all-option.patch
Description: Binary data
v23-0003-Additional-test-cases.patch
Description: Binary data
