On Tue, Mar 25, 2025 at 3:22 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Dear Shubham, > > > The attached patches contain the suggested changes. > > Thanks for updating the patch. I reviewed only 0001 because they would be > committed separately. > Few comments: > > 01. > ``` > + For every non-template database on the source server, create one > + subscription on the target server in the database with the same name. > ``` > > It is quite confusing for me; We do not have to describe users that this > command > checks databases of the source server. How about something like: > "Create one subscription per all non-template databases on the target server." >
The new description doesn't mention the link between the source and target database. And I think it's incorrect. Not all databases on the target server will receive a subscription. Only those which have the same name as a database on the source server. Am I correct? I prefer the previous wording, even if it's a bit complex, over a simpler but incorrect description. -- Best Wishes, Ashutosh Bapat
