On Wed, Mar 26, 2025 at 3:54 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Mar 25, 2025 at 5:30 PM Ashutosh Bapat > <ashutosh.bapat....@gmail.com> wrote: > > > > On Thu, Mar 20, 2025 at 5:54 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > * <refsynopsisdiv> > > > + <cmdsynopsis> > > > + <command>pg_createsubscriber</command> > > > + <arg rep="repeat"><replaceable>option</replaceable></arg> > > > + <group choice="plain"> > > > + <group choice="req"> > > > + <arg choice="plain"><option>-a</option></arg> > > > + <arg choice="plain"><option>--all</option></arg> > > > + </group> > > > + <group choice="req"> > > > + <arg choice="plain"><option>-D</option> </arg> > > > + <arg choice="plain"><option>--pgdata</option></arg> > > > + </group> > > > + <replaceable>datadir</replaceable> > > > + <group choice="req"> > > > + <arg choice="plain"><option>-P</option></arg> > > > + <arg choice="plain"><option>--publisher-server</option></arg> > > > + </group> > > > + <replaceable>connstr</replaceable> > > > > > > Most of this is unrelated to this patch. I suggest making a top-up > > > patch, we can commit it separately. > > > > Isn't this documenting -a/--all option in synopsis. Why do you think > > it's unrelated? > > > > I was not clear at that stage whether to include it along with the > core patch, but today, I looked at it while responding to Euler and > found that it is not required. We can still discuss whether to include > it, but the main patch can be committed even without this. >
I've created a separate thread [1] to continue the discussion about the synopsis. ====== [1] https://www.postgresql.org/message-id/CAHut%2BPueY_DyuBy6SuvJev2DWJVGtg%3D9WG9WXvYQDJu39gV6TQ%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
