On Sat, May  3, 2025 at 01:46:29AM +0200, Jelte Fennema-Nio wrote:
> On Fri, 2 May 2025 at 04:45, Bruce Momjian <br...@momjian.us> wrote:
> >
> > I have committd the first draft of the PG 18 release notes.  The item
> > count looks strong:
> 
> Thanks for all the work. Some notes:
> 
> 1. There's currently no mention that protocol version 3.2 was
> introduced in this release. I'm not sure where/how this should be
> mentioned, but I definitely think it should be somewhere. It's a
> pretty major change. One option is to replace/amend the "Make cancel
> request keys 256 bits" item. Maybe replace that with something like:
> "Postgres 18 introduces protocol version 3.2. This is the first new
> protocol version since 3.0, which was introduced in Postgres 7.4. This
> new protocol version 3.2 allows a server to use longer cancel request
> keys. When the client advertises support for protocol version 3.2 (or
> higher) Postgres 18 will use a cancel key size of 256 bits."

Okay, I added a mention next to the libpq version function entries.

> 2. Obviously biased since it's my contribution, but I think d38bab5
> might deserve a mention.

I disagree.  pgbench limits like this are not something we give much
detail around error avoidance to in the release notes.

> 3. The "Add PQtrace() output..." commitlist should also contain 7adec2d5fc

Added.  Patch attached.

-- 
  Bruce Momjian  <br...@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.
diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml
index 2654960eef8..ed7fa5d903f 100644
--- a/doc/src/sgml/release-18.sgml
+++ b/doc/src/sgml/release-18.sgml
@@ -2146,6 +2146,10 @@ Author: Robert Haas <rh...@postgresql.org>
 Add function PQfullProtocolVersion() to report the full, including minor, protocol version number (Jacob Champion, Jelte Fennema-Nio)
 <ulink url="&commit_baseurl;cdb6b0fdb">&sect;</ulink>
 </para>
+
+<para>
+This release introduces wire protocol version 3.2.
+</para>
 </listitem>
 
 <!--
@@ -2196,6 +2200,8 @@ Author: Álvaro Herrera <alvhe...@alvh.no-ip.org>
 2024-08-16 [b8b3f861f] libpq: Trace all messages received from the server
 Author: Robert Haas <rh...@postgresql.org>
 2025-02-24 [e87c14b19] libpq: Trace all NegotiateProtocolVersion fields
+Author: Álvaro Herrera <alvhe...@alvh.no-ip.org>
+2024-08-09 [7adec2d5f] libpq: Trace StartupMessage/SSLRequest/GSSENCRequest cor
 -->
 
 <listitem>

Reply via email to