On Sat, May 3, 2025 at 09:40:47PM +0200, Jelte Fennema-Nio wrote: > On Sat, 3 May 2025 at 18:19, Bruce Momjian <br...@momjian.us> wrote: > > I moved the item and added some text, patch attached. > > LGTM, apart from the typo in the word "client' (it's spelled as > "cliient" in the diff).
Thanks, fixed. > Noticed a few other small things when rereading: > > 1. "Add libpq functions and environment..." should be "Add libpq > connection parameters and environment Fixed. > 2. "Allow the specification of non-overlapping PRIMARY KEY and UNIQUE > constraints" has no commit attached to it. I noticed this because it > wasn't fully clear to me what this feature entailed, so I wanted to > look at it in more detail. Fixed. > 3. "Report search_path changes to the client." is currently in the > libpq section, but this is a server-only change. So that seems a bit > strange. Not sure where to put it though. Not sure. The only idea I had was server configuration, which doesn't match well. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.