On Wed, May 7, 2025 at 4:55 AM Ian Lawrence Barwick <[email protected]>
wrote:
> Version which applies/builds against current HEAD attached. I haven't yet
> had a chance to look at the code beyond fixing it, however.
>
I too, have wanted this over the years, so +1 on the idea.
Quick review: nice patch, very thorough; applies cleanly; all tests pass;
acts as I would expect when testing manually.
Minor pgindent issue in the comment in src/backend/catalog/dependency.c
Would be nice to have test coverage of our special "single dash" case, e.g.
select regdatabase('-')::oid;
0
Cheers,
Greg
--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support
