On Tue, May 13, 2025 at 8:26 PM David Rowley <dgrowle...@gmail.com> wrote: > On Tue, 13 May 2025 at 04:03, Richard Guo <guofengli...@gmail.com> wrote: > > While adding a new field to PlannerGlobal in another patch, I noticed > > that although most fields are explicitly initialized, a few are not. > > This doesn't cause any functional issues, since makeNode() zeroes all > > fields by default. However, the inconsistency stood out to me, so I > > wrote the attached patch to explicitly initialize the remaining fields > > for clarity and consistency. > > > > Does this seem worthwhile? Or should we simply rely on makeNode() for > > zero-initialization and consider this unnecessary? > > These should be zeroed explicitly.
Thank you for confirming. I've pushed this patch to master. Thanks Richard