On Fri, May 16, 2025 at 04:05:01PM +0530, Shaik Mohammad Mujeeb wrote: > This conversion is intentional - most likely to match the bigint > type of the queryid column in pg_stat_statements. However, without > an explicit comment, this can be misleading. A beginner reading this > might misinterpret it as an unintentional overflow or bug and raise > unnecessary concerns. Therefore, it´s worth adding a brief comment > clarifying the intent behind this assignment.
I don't quite see the value in the comment addition you are suggesting here: all the user-facing features related to query IDs use signed 64b integers, and are documented as such in the official docs. The fact that we store an unsigned value in the backend core code is an internal implementation artifact, the important point is that we have a value stored in 8 bytes. -- Michael
signature.asc
Description: PGP signature
