On Tue, 20 May 2025 at 03:05, Peter Eisentraut <pe...@eisentraut.org> wrote: > Or why not store query IDs as int64_t > internally, too?
I had the same thought. Changing to int64 seems like a good and less bug-prone tidy-up. I expected we ended up with uint64 as the previous type was uint32, and uint64 is the natural selection for widening that to 64 bits. Aside from the struct field types changing for Query.queryId, PlannedStmt.queryId and PgBackendStatus.st_query_id, the external-facing changes are limited to: 1. pgstat_report_query_id() now returns int64 instead of uint64 2. pgstat_get_my_query_id() now returns int64 instead of uint64 3. pgstat_report_query_id()'s first input parameter is now int64 If we were to clean this up, then I expect it's fine to wait until v19, as it's not really a problem that's new to v18. David
v1-0001-Change-internal-queryid-type-to-int64.patch
Description: Binary data
